feat: allow SameSite case insensitive binding #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #6092 enum `SameSite` is: ```java package io.micronaut.http.cookie; public enum SameSite { Lax, Strict, None; } ``` I think it should have been something like: ```java package io.micronaut.http.cookie; import com.fasterxml.jackson.annotation.JsonValue; public enum SameSite { LAX("Lax"), STRICT("Strict"), NONE("None"); private final String value; SameSite(String value) { this.value = value; } @JsonValue public String toString() { return this.value; } } ``` However, changing the enum is a breaking change. Henche, I have introduced a type converter to allow for lowercase binding. IntelliJ IDEA suggests lowercase values. Users type a lowercase value as their IDE suggests and they are confused because it does not work. See: micronaut-projects/micronaut-security#755 Also, test SameSite JSON rendering
sdelamo
added a commit
to micronaut-projects/micronaut-security
that referenced
this pull request
Oct 7, 2021
sdelamo
added a commit
to micronaut-projects/micronaut-security
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6092
enum
SameSiteis:I think it should have been something like:
However, changing the enum is a breaking change. Henche, I have introduced a type converter to allow for lowercase binding.
IntelliJ IDEA suggests lowercase values.
Users type a lowercase value as their IDE suggests and they are confused because it does not work.
See: micronaut-projects/micronaut-security#755
Also, test SameSite JSON rendering