Create new netty-graal module for native image configuration #6657
Conversation
The graal configuration that netty needs was previously only present in the http-netty module (HttpNettyFeature). This patch creates a new netty-graal module for that configuration, so that other modules that use netty but not http-netty (in particular micronaut-grpc) can use the same configuration. Resolves #6650
|
I've created micronaut-projects/micronaut-grpc#437 in gRPC module with the changes to use this once we release Micronaut 3.3.0 |
|
I am still unconvinced a new module needed. Especially if #6661 is merged in which case that module will be need to allow configurability of the Netty buffer allocator |
|
Then #6661 should also be in the new module |
|
Why? it relates to configuring the buffer allocator and is in the netty-buffer module. What more appropriate module would it live in? Configuring the buffer allocator seems something that would be desirable in a gRPC app as well |
|
imo the purpose of the netty-buffer module is to provide the netty implementation of |
|
moved this to buffer-netty too, as per #6661 |
* Create new netty-graal module for native image configuration The graal configuration that netty needs was previously only present in the http-netty module (HttpNettyFeature). This patch creates a new netty-graal module for that configuration, so that other modules that use netty but not http-netty (in particular micronaut-grpc) can use the same configuration. Resolves #6650 * checkstyle * move changes to buffer-netty module
The graal configuration that netty needs was previously only present in the http-netty module (HttpNettyFeature). This patch creates a new netty-graal module for that configuration, so that other modules that use netty but not http-netty (in particular micronaut-grpc) can use the same configuration.
Resolves #6650