Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow test initialization ImmutableSortedStringsArrayMapTest (#6791) #6799

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Fix slow test initialization ImmutableSortedStringsArrayMapTest (#6791) #6799

merged 1 commit into from
Jan 25, 2022
+29 −18

Conversation

alextu
Copy link
Contributor

@alextu alextu commented Jan 25, 2022 •
edited
Loading

This also moves the init logic in Spock's setupSpec() hook, exposing only the 2 fields necessary for the tests
The actual speed up bit is there:

        keys.removeAll(present)

@graemerocher graemerocher merged commit 0845022 into micronaut-projects:3.2.x Jan 25, 2022
@graemerocher
Copy link
Contributor

Thanks for the contribution!

@alextu alextu deleted the atual/fix-slow-test branch January 25, 2022 09:55
@timyates timyates mentioned this pull request Jan 25, 2022
Closed
yawkat pushed a commit that referenced this pull request Jun 24, 2022
@alextu @yawkat
Fix slow test initialization ImmutableSortedStringsArrayMapTest (#6791)…
af8133d 
… (#6799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alextu @graemerocher