Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Micronaut Parent POM #7120

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Update Micronaut Parent POM #7120

merged 2 commits into from
Mar 24, 2022

Conversation

alvarosanchez
Copy link
Member

Refreshes Maven plugin versions. It also changes the GraalVM Native Plugin definition
by not manually passing anymore the application JAR as a classpath argument, since this
is now handled in the Native Plugin (see graalvm/native-build-tools#226)

This PR requires Native Plugin version 0.9.11 released before merging.

@alvarosanchez alvarosanchez added this to the 3.4.0 milestone Mar 21, 2022
@alvarosanchez alvarosanchez requested review from melix and sdelamo March 21, 2022 18:12
@sdelamo sdelamo added the status: awaiting third-party Awaiting changes to a third party library label Mar 21, 2022
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you use 0.9.11, which is correct since it's technically a breaking change. Just making sure this doesn't get merged until that version is out :)

@sdelamo sdelamo modified the milestones: 3.4.0, 3.5.0 Mar 22, 2022
@alvarosanchez
Copy link
Member Author

I wonder how could the build pass since I used a non-existent version? Weren't we checking that?

@melix
Copy link
Contributor

melix commented Mar 22, 2022

We're checking the BOM, not the parent POM afaik.

@alvarosanchez
Copy link
Member Author

The version is changed in the catalog file, not the parent POM.

@melix
Copy link
Contributor

melix commented Mar 22, 2022

The catalog file isn't checked: we check the generated BOM.

@alvarosanchez
Copy link
Member Author

Ok, understood. Thanks!

@alvarosanchez alvarosanchez removed the status: awaiting third-party Awaiting changes to a third party library label Mar 24, 2022
@alvarosanchez alvarosanchez marked this pull request as ready for review March 24, 2022 11:28
@alvarosanchez
Copy link
Member Author

@sdelamo this is ready to be merged into 3.4.x

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@graemerocher graemerocher modified the milestones: 3.5.0, 3.4.1 Mar 24, 2022
@sdelamo sdelamo merged commit c952759 into 3.4.x Mar 24, 2022
@sdelamo sdelamo deleted the update_parent_pom branch March 24, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants