fix: add interceptor around parameterized features #953
+31
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a feature is using `@Unroll` (which is implicit in recent versions of Spock), we needed to add the interceptor to the iteration interceptor handler instead of the standard handler. This bug was visible in #911 where specs that were parameterized did not properly revert the transaction between iterations. Closes #911
timyates
added
lang: groovy
|
Thanks @dstepanov for all the help 👍 |
sdelamo
approved these changes
Feb 16, 2024
|
timyates
added a commit
that referenced
this pull request
Feb 16, 2024
When a feature is using `@Unroll` (which is implicit in recent versions of Spock), we needed to add the interceptor to the iteration interceptor handler instead of the standard handler. This bug was visible in #911 where specs that were parameterized did not properly revert the transaction between iterations. Closes #911
This was referenced Feb 16, 2024
sdelamo
pushed a commit
that referenced
this pull request
Feb 16, 2024
When a feature is using `@Unroll` (which is implicit in recent versions of Spock), we needed to add the interceptor to the iteration interceptor handler instead of the standard handler. This bug was visible in #911 where specs that were parameterized did not properly revert the transaction between iterations. Closes #911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a feature is using
@Unroll(which is implicit in recent versions of Spock), we needed to add the interceptor to the iteration interceptor handler instead of the standard handler.This bug was visible in #911 where specs that were parameterized did not properly revert the transaction between iterations.
Closes #911