[Main][Task]27749889: Change AISKU Sync Mode to Receive #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karlie-777
commented
Apr 21, 2024
| @@ -92,7 +92,8 @@ const defaultConfigValues: IConfigDefaults<IConfiguration & IConfig> = { | |||
| ), | |||
| extensionConfig: cfgDfMerge<{[key: string]: any}>({ | |||
| ["AppInsightsCfgSyncPlugin"]: cfgDfMerge<ICfgSyncConfig>({ | |||
| cfgUrl: CONFIG_ENDPOINT_URL | |||
| cfgUrl: CONFIG_ENDPOINT_URL, | |||
| syncMode: ICfgSyncMode.Receive | |||
There was a problem hiding this comment.
change the AISKU default receive mode to "receive" (will call "updateCfg" to update current core.config), previous one is "broadcast" (which means only send events out but not receiving any incoming changes)
Karlie-777
commented
Apr 21, 2024
| @@ -317,7 +317,9 @@ export class CfgSyncPlugin extends BaseTelemetryPlugin implements ICfgSyncPlugin | |||
| if (JSON) { | |||
| let cdnCfg = JSON.parse(response); //comments are not allowed | |||
| let cfg = applyCdnfeatureCfg(cdnCfg, _self.core); | |||
| cfg && _setCfg(cfg, isAutoSync); | |||
| let newCfg = cfg && isPlainObject(cfg) && _replaceTartgetByKeys(cfg); | |||
| newCfg && _setCfg(newCfg, isAutoSync); | |||
There was a problem hiding this comment.
previous design: any configs from cdn, they will be directly applied to current core.config (it was designed to use blkCdnCfg to control if we need to apply cdn changes or not).
Current:
So add an extra layer, even if blkCdnCfg is set to false, any config values defined in nonOverrideConfigs will not be replaced by cdn configs.
MSNev
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.