New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Snippet Setup pollutes the global namespace (window) #974
Comments
- New Snippet Setup pollutes the global namespace (window) #974
- New Snippet Setup pollutes the global namespace (window) #974
- New Snippet Setup pollutes the global namespace (window) #974
- New Snippet Setup pollutes the global namespace (window) #974
- New Snippet Setup pollutes the global namespace (window) #974
An update snippet which address this issue has been checked in with #1258 |
Included in v 2.5.5 which is now fully deployed |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Using the new Snippet Setup introduces 5 global variables (on the window object). I can see the following being added to window.
aisdk
ainame
appInsightsSDK
appInsights
sdkInstance
Is this really necessary? Is there any usecase for when I should use / change these variables? I'd like a minimal global footprint (
appInsights
) and scope the rest to a local function. IF, they need to be global for some reason, a consistent prefix should be in place IMHO;sdkInstance
feels very generic.The text was updated successfully, but these errors were encountered: