-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture of InProc Telemetry Type not working properly #2774
Comments
So after further analysis, the primary difference with the latest GA release is any custom instrumentation method invocations are by default tagged with telemetry type as "Request" instead of earlier behavior where they were marked inProc when part of another parent invocation. We have tried two combinations
So looking for suggestions to have the best of both worlds :) We are ok to disable InProc capture, but we want the custom instrumentation requests to be captured as standalone requests only when there is no traceparent or invocation not part of a parent request span. This is currently possible in 3.3.1 GA with inProc capture disabled and only having custom instrumentation enabled |
hi @zoomingrocket, thanks for reporting this! this behavior was changed by #2513, but I've sent #2776 which should bring the best of both worlds (and bring your particular use case back to the old behavior) |
@trask - Thanks appreciate the update, happy to test a snapshot build when available. |
See #2774 Co-authored-by: github-actions[bot] <github-action[bot]@users.noreply.github.com>
@trask - Verified with snapshot build, behavior is back to normal. Thanks! |
3.4.7 is now released: https://github.com/microsoft/ApplicationInsights-Java/releases |
Expected behavior
We were currently using App Insight 3.3.1 GA and started evaluating 3.4.5 GA. Immediately after switching over to the new release, we started noticing a huge spike of InProc invocations getting captured as "Request" type.
We are using "captureControllerSpans" as true in config JSON & customInstrumentation
3.3.1 GA Release behavior
Actual behavior
3.4.5 GA Release Behavior
To Reproduce
We are using a COTs Middleware system and this is noticed for all requests captured where inProc is now classified as "Request" type instead
Sample Application
N/A
System information
Please provide the following information:
Logs
Let me know what specific log we should capture which will be helpful in debugging this behavior
Screenshots
Posted above
The text was updated successfully, but these errors were encountered: