Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]15209420: add web snippet prefix and config #1012

Merged
merged 7 commits into from
Oct 18, 2022
Merged

[Task]15209420: add web snippet prefix and config #1012

merged 7 commits into from
Oct 18, 2022

Conversation

Karlie-777
Copy link

@Karlie-777 Karlie-777 commented Sep 19, 2022 •
edited

  1. change config name snippet to webInstrumentation
  2. old config/methods should still work
  3. add client config for JS SDK
  4. add client config for snippet src
  5. add more test coverages

hectorhdzg
hectorhdzg reviewed Oct 18, 2022
View reviewed changes
Library/Config.ts Outdated Show resolved Hide resolved
hectorhdzg
hectorhdzg approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Karlie-777 Karlie-777 merged commit 4c65638 into develop Oct 18, 2022
@hectorhdzg hectorhdzg deleted the karlie/addsnippetprefix branch November 9, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@MSNev MSNev Awaiting requested review from MSNev

@ramthi ramthi Awaiting requested review from ramthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Karlie-777 @hectorhdzg