Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Negative Average Duration #1039

Conversation

JacksonWeber
Copy link
Contributor

This PR sets averageRequestExecutionTime to 0 when given a negative totalRequestExecutionTime assuming that in this case something is wrong with the input executionTime.

This PR also adds support for more EU regions as defined by:
https://github.com/aep-health-and-standards/Telemetry-Collection-Spec/blob/main/ApplicationInsights/statsbeat/eudb.md

And shortens the shortHost name to be within spec:
https://github.com/aep-health-and-standards/Telemetry-Collection-Spec/pull/139

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonWeber JacksonWeber merged commit 39213a3 into microsoft:develop Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants