Automatically handle request/dependency correlation in Azure Functions #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Dec 5, 2022
MSNev
approved these changes
Dec 5, 2022
|
Hey guys, @MSNev , @JacksonWeber, @hectorhdzg this PR introduces a critical bug. Starting from version 2.4.0 when this PR was merged the Async functions stopped to work because the AzureFunctionsHook calls originalCallback but does not handle a case when this callback can return promise. Feedback from me as an Azure customer. My function app async function basically stopped working properly because of that issue that was very hard to track down, which can impact other Azure customers and production applications as well. |
|
Please see the test evidence here Azure/azure-functions-nodejs-worker#652 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.