Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal fix for #1226 #1241

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Minimal fix for #1226 #1241

merged 2 commits into from
Dec 13, 2023

Conversation

datenreisender
Copy link

A minimal fix for trying to load the default configuration during runtime which only exists in the source code. That loading previously failed when the code is bundled. So now the default configuration is already loaded when bundling the code.

Fixes #1226.

A minimal fix for trying to load the default configuration during
runtime which only exists in the source code. That loading previously
failed when the code is bundled. So now the default configuration is
already loaded when bundling the code.
@datenreisender
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution, we will use minimal fix for now, as we need to revisit this functionality to have a more adequate fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApplicationInsights:Invalid JSON config file when using APPLICATIONINSIGHTS_CONNECTION_STRING
2 participants