Add support for pre aggregated metrics #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still working on tests |
MSNev
reviewed
Mar 1, 2021
MSNev
approved these changes
Mar 1, 2021
lzchen
reviewed
Mar 1, 2021
lzchen
reviewed
Mar 1, 2021
lzchen
reviewed
Mar 1, 2021
lzchen
reviewed
Mar 1, 2021
lzchen
reviewed
Mar 1, 2021
lzchen
reviewed
Mar 1, 2021
| private _handle: NodeJS.Timer; | ||
| private _isEnabled: boolean; | ||
| private _isInitialized: boolean; | ||
| private static _dependencyCountersCollection: Array<AggregatedMetricCounter>; |
There was a problem hiding this comment.
I'm wondering why you need to a keep a collection of counters? We only need one counter per standard metric.
There was a problem hiding this comment.
AggregatedMetricCounter here is a class that have all necessary counters plus the dimensions, we need a collection to send all data by dimensions
lzchen
reviewed
Mar 1, 2021
hectorhdzg
changed the title
lzchen
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including following metrics:
Dependency duration
Server response time
Exceptions count
Traces count