Roles support, Endpoint redirects and ping interval hints for Live Metrics #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library/QuickPulseStateManager.ts
Outdated
| @@ -29,6 +29,8 @@ class QuickPulseStateManager { | |||
| private _metrics: {[name: string]: Contracts.MetricQuickPulse} = {}; | |||
| private _documents: Contracts.DocumentQuickPulse[] = []; | |||
| private _collectors: {enable: (enable: boolean) => void}[] = []; | |||
| private _rediectedHost: string = null; | |||
There was a problem hiding this comment.
Just curious - why this vs updating the host in config? Is the idea that we don't want to expose the redirection when it happens?
There was a problem hiding this comment.
We do not want to make this change persistent, if the agent is restarted, then it should start polling the endpoint it was originally configured to. It will be redirected again
ramthi
reviewed
Mar 6, 2021
ramthi
reviewed
Mar 6, 2021
hectorhdzg
reviewed
Mar 9, 2021
hectorhdzg
reviewed
Mar 9, 2021
| @@ -130,7 +132,8 @@ class QuickPulseStateManager { | |||
| this._ping(envelope); | |||
| } | |||
|
|
|||
| let currentTimeout = this._isCollectingData ? QuickPulseStateManager.POST_INTERVAL : QuickPulseStateManager.PING_INTERVAL; | |||
| let pingInterval = this._pollingIntervalHint > 0 ? this._pollingIntervalHint : QuickPulseStateManager.PING_INTERVAL; | |||
There was a problem hiding this comment.
Is it possible for endpoint to return negative polling internal hints?, how the SDK will come back to original ping interval?
There was a problem hiding this comment.
No, the endpoint will not return negative values, and the SDK must not go back to the original ping interval unless it is restarted.
hectorhdzg
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.