Adding 206 response handling from Breeze #752
Conversation
Adding task to clean old files
hectorhdzg
changed the title
| envelopes.forEach(envelope => { | ||
| var payload: string = this._stringify(envelope); | ||
| if (typeof payload !== "string") { | ||
| return; |
There was a problem hiding this comment.
If there is a single "invalid" envelope that can't be stringified, (say in the middle of the payload), won't this case only half the batch to be sent?
Not that I can think of a normal case where JSON.stringify() would fail... Just looking for corner cases.
There was a problem hiding this comment.
We want to drop the individual "wrong" event and continue with others, I'm trying to keep previous logic, this change is mainly focused on having the envelopes available in this class instead of payload like before, allowing us to filter them for retriable response codes.
Library/Sender.ts
Outdated
|
|
||
| // Mode 600 is w/r for creator and no read access for others (only applies on *nix) | ||
| // For Windows, ACL rules are applied to the entire directory (see logic in _confirmDirExists and _applyACLRules) | ||
| Logging.info(Sender.TAG, "saving data to disk at: " + fileFullPath); | ||
| fs.writeFile(fileFullPath, payload, { mode: 0o600 }, (error) => this._onErrorHelper(error)); | ||
| fs.writeFile(fileFullPath, JSON.stringify(envelopes), { mode: 0o600 }, (error) => this._onErrorHelper(error)); |
There was a problem hiding this comment.
2 questions
- I'm assuming that we don't need to worry about back compat for loading previous version persisted items
- Based on the try/catch stringify check when sending requests do we want to do that here as well so entire batches don't get dropped.
There was a problem hiding this comment.
Yours also explicitly converting the string to utf8 prior to reading -- should ensure that it's written as such also.
There was a problem hiding this comment.
We will not support old AppInsights files because the telemetry was stored differently, this change will be part of major version update of the SDK, older files will be automatically cleaned after expiration is reached
Adding task to clean old files