Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Website instance ID when running in Azure #836

Merged
merged 4 commits into from
Sep 9, 2021
Merged

Use Website instance ID when running in Azure #836

merged 4 commits into from
Sep 9, 2021

Conversation

hectorhdzg
Copy link
Member

No description provided.

@heyams
Copy link

heyams commented Sep 9, 2021

where is the code it defaults to hostname when instance_id is not available?

@hectorhdzg
Copy link
Member Author

@heyams code is here
https://github.com/microsoft/ApplicationInsights-node.js/blob/develop/Library/Context.ts#L47 it will be overwritten by this telemetry processor if enabled and running in Azure

@hectorhdzg hectorhdzg merged commit a327c10 into develop Sep 9, 2021
@hectorhdzg hectorhdzg deleted the hectorhdzg/azureroleinstance branch September 15, 2021 21:29
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSNev MSNev MSNev approved these changes

@heyams heyams heyams approved these changes

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hectorhdzg @heyams @MSNev