Fix issue loading SDK version #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiao-lix
reviewed
Sep 20, 2021
| } | ||
| } | ||
|
|
||
| Context.sdkVersion = APPLICATION_INSIGHTS_SDK_VERSION; |
There was a problem hiding this comment.
Just curious - why do you change the version to hardcoded rather than extract from package json?
There was a problem hiding this comment.
Looking at Statsbeat data we can tell package json logic fails a lot, this will ensure we send correct version all the times
xiao-lix
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test to ensure version is updated during releases