Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace for custom metrics #869

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

hectorhdzg
Copy link
Member

Fixes #609

metricTelemetry = {
name: "TestName",
value: 123,
namespace: "TestNamespace",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we should be adding to the web code as well?
We only have these
export class DataPoint {

/**
 * Name of the metric.
 */
public name: string;

/**
 * Metric type. Single measurement or the aggregated value.
 */
public kind: DataPointType = DataPointType.Measurement;

/**
 * Single value for measurement. Sum of individual measurements for the aggregation.
 */
public value: number;

/**
 * Metric weight of the aggregated metric. Should not be set for a measurement.
 */
public count: number;

/**
 * Minimum value of the aggregated metric. Should not be set for a measurement.
 */
public min: number;

/**
 * Maximum value of the aggregated metric. Should not be set for a measurement.
 */
public max: number;

/**
 * Standard deviation of the aggregated metric. Should not be set for a measurement.
 */
public stdDev: number;

}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you should, "ns" is the actual field we put in the envelope, namespace is the property name of the class we expose in the API

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will raise an issue on AI-JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to provide metric namespace
2 participants