Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to http dependency when host is missing #885

Conversation

MohammedFoysal
Copy link
Contributor

@MohammedFoysal MohammedFoysal commented Jan 18, 2022

Whenever the hostname is populated but the host is missing, use the hostname and add in the path. This fixes the issue where the path is missing from app insights detailed in this issue #886

@ghost
Copy link

ghost commented Jan 18, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@MohammedFoysal
Copy link
Contributor Author

@hectorhdzg Apologies for the delay, the CLA has now been signed and the PR is ready to go 👍

@hectorhdzg hectorhdzg merged commit 38b2430 into microsoft:develop Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants