From ede3f5721ee8b40b14332fdffb906ccd7731d397 Mon Sep 17 00:00:00 2001 From: asos-craigmorten Date: Thu, 30 Apr 2020 15:06:48 +0100 Subject: [PATCH 1/2] fix: following contributing guidelines resulted in updated package-lock package-lock.json should match the package.json version --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 27c8c9ec..52a56599 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "applicationinsights", - "version": "1.7.3", + "version": "1.7.5", "lockfileVersion": 1, "requires": true, "dependencies": { From 0be48dfc4dd17c468ef8960bcc9e4b4ebf0e068d Mon Sep 17 00:00:00 2001 From: asos-craigmorten Date: Thu, 30 Apr 2020 15:58:16 +0100 Subject: [PATCH 2/2] fix: all typos found --- AutoCollection/HttpDependencyParser.ts | 4 ++-- AutoCollection/HttpRequestParser.ts | 2 +- AutoCollection/RequestParser.ts | 2 +- Bootstrap/DataModel.ts | 2 +- Bootstrap/Default.ts | 2 +- Declarations/Contracts/TelemetryTypes/RequestTelemetry.ts | 2 +- Declarations/Contracts/TelemetryTypes/Telemetry.ts | 4 ++-- Library/Channel.ts | 2 +- Library/Config.ts | 2 +- Library/NodeClient.ts | 2 +- Library/RequestResponseHeaders.ts | 4 ++-- Library/Sender.ts | 6 +++--- Schema/PublicSchema/ContextTagKeys.bond | 2 +- Schema/PublicSchema/RemoteDependencyData.bond | 2 +- Schema/PublicSchema/RequestData.bond | 2 +- 15 files changed, 20 insertions(+), 20 deletions(-) diff --git a/AutoCollection/HttpDependencyParser.ts b/AutoCollection/HttpDependencyParser.ts index 3a7ef221..a41c3856 100644 --- a/AutoCollection/HttpDependencyParser.ts +++ b/AutoCollection/HttpDependencyParser.ts @@ -11,7 +11,7 @@ import RequestParser = require("./RequestParser"); import CorrelationIdManager = require("../Library/CorrelationIdManager"); /** - * Helper class to read data from the requst/response objects and convert them into the telemetry contract + * Helper class to read data from the request/response objects and convert them into the telemetry contract */ class HttpDependencyParser extends RequestParser { private correlationId: string; @@ -127,7 +127,7 @@ class HttpDependencyParser extends RequestParser { options.search = parsedQuery.search; } - // Simiarly, url.format ignores hostname and port if host is specified, + // Similarly, url.format ignores hostname and port if host is specified, // even if host doesn't have the port, but http.request does not work // this way. It will use the port if one is not specified in host, // effectively treating host as hostname, but will use the port specified diff --git a/AutoCollection/HttpRequestParser.ts b/AutoCollection/HttpRequestParser.ts index 748b9f6f..3abd670b 100644 --- a/AutoCollection/HttpRequestParser.ts +++ b/AutoCollection/HttpRequestParser.ts @@ -13,7 +13,7 @@ import Tracestate = require("../Library/Tracestate"); import Traceparent = require("../Library/Traceparent"); /** - * Helper class to read data from the requst/response objects and convert them into the telemetry contract + * Helper class to read data from the request/response objects and convert them into the telemetry contract */ class HttpRequestParser extends RequestParser { private static keys = new Contracts.ContextTagKeys(); diff --git a/AutoCollection/RequestParser.ts b/AutoCollection/RequestParser.ts index d631f257..724142bb 100644 --- a/AutoCollection/RequestParser.ts +++ b/AutoCollection/RequestParser.ts @@ -1,5 +1,5 @@ /** - * Base class for helpers that read data from HTTP requst/response objects and convert them + * Base class for helpers that read data from HTTP request/response objects and convert them * into the telemetry contract objects. */ abstract class RequestParser { diff --git a/Bootstrap/DataModel.ts b/Bootstrap/DataModel.ts index 092f3bc9..532b7ae3 100644 --- a/Bootstrap/DataModel.ts +++ b/Bootstrap/DataModel.ts @@ -36,7 +36,7 @@ export interface DiagnosticLog { exception?: string /** - * Any custom data related to the error/application/operation. Each field should havea string value + * Any custom data related to the error/application/operation. Each field should have a string value * Examples: operation, siteName, ikey, extensionVersion, sdkVersion, subscriptionId */ properties: { [key: string]: string }; diff --git a/Bootstrap/Default.ts b/Bootstrap/Default.ts index cabc6560..27c2af86 100644 --- a/Bootstrap/Default.ts +++ b/Bootstrap/Default.ts @@ -31,7 +31,7 @@ export function setLogger(logger: DiagnosticLogger) { } /** - * Sets the string which is prefixed to the exsting sdkVersion, e.g. `ad_`, `alr_` + * Sets the string which is prefixed to the existing sdkVersion, e.g. `ad_`, `alr_` * @param prefix string prefix, including underscore. Defaults to `ad_` */ export function setUsagePrefix(prefix: string) { diff --git a/Declarations/Contracts/TelemetryTypes/RequestTelemetry.ts b/Declarations/Contracts/TelemetryTypes/RequestTelemetry.ts index 2d11f4b2..a3b5c9e7 100644 --- a/Declarations/Contracts/TelemetryTypes/RequestTelemetry.ts +++ b/Declarations/Contracts/TelemetryTypes/RequestTelemetry.ts @@ -1,7 +1,7 @@ import { Telemetry } from "./Telemetry"; /** - * Telemetry about the incoming request processsed by the application + * Telemetry about the incoming request processed by the application */ export interface RequestTelemetry extends Telemetry { diff --git a/Declarations/Contracts/TelemetryTypes/Telemetry.ts b/Declarations/Contracts/TelemetryTypes/Telemetry.ts index 00ce68b4..86b7082a 100644 --- a/Declarations/Contracts/TelemetryTypes/Telemetry.ts +++ b/Declarations/Contracts/TelemetryTypes/Telemetry.ts @@ -1,9 +1,9 @@ /** - * Base telemetry interface encapsulating comming properties + * Base telemetry interface encapsulating coming properties */ export interface Telemetry { /** - * Telemetry time stamp. When it is not specified, current tiestamp will be used. + * Telemetry time stamp. When it is not specified, current timestamp will be used. */ time?: Date; /** diff --git a/Library/Channel.ts b/Library/Channel.ts index 2a55ec45..9f155a6a 100644 --- a/Library/Channel.ts +++ b/Library/Channel.ts @@ -26,7 +26,7 @@ class Channel { /** * Enable or disable disk-backed retry caching to cache events when client is offline (enabled by default) * These cached events are stored in your system or user's temporary directory and access restricted to your user when possible. - * @param value if true events that occured while client is offline will be cached on disk + * @param value if true events that occurred while client is offline will be cached on disk * @param resendInterval The wait interval for resending cached events. * @param maxBytesOnDisk The maximum size (in bytes) that the created temporary directory for cache events can grow to, before caching is disabled. * @returns {Configuration} this class diff --git a/Library/Config.ts b/Library/Config.ts index d9c716f0..a8b11669 100644 --- a/Library/Config.ts +++ b/Library/Config.ts @@ -92,7 +92,7 @@ class Config { this.httpsAgent = undefined; this.profileQueryEndpoint = csCode.ingestionendpoint || csEnv.ingestionendpoint || process.env[Config.ENV_profileQueryEndpoint] || this.endpointBase; this._quickPulseHost = csCode.liveendpoint || csEnv.liveendpoint || process.env[Config.ENV_quickPulseHost] || Constants.DEFAULT_LIVEMETRICS_HOST; - // Parse quickPulseHost if it startswith http(s):// + // Parse quickPulseHost if it starts with http(s):// if (this._quickPulseHost.match(/^https?:\/\//)) { this._quickPulseHost = url.parse(this._quickPulseHost).host; } diff --git a/Library/NodeClient.ts b/Library/NodeClient.ts index 6bfa0262..dff48f03 100644 --- a/Library/NodeClient.ts +++ b/Library/NodeClient.ts @@ -15,7 +15,7 @@ import Contracts = require("../Declarations/Contracts"); class NodeClient extends TelemetryClient { /** - * Log RequestTelemetry from HTTP request and response. This method will log immediately without waitng for request completion + * Log RequestTelemetry from HTTP request and response. This method will log immediately without waiting for request completion * and it requires duration parameter to be specified on NodeHttpRequestTelemetry object. * Use trackNodeHttpRequest function to log the telemetry after request completion * @param telemetry Object encapsulating incoming request, response and duration information diff --git a/Library/RequestResponseHeaders.ts b/Library/RequestResponseHeaders.ts index 12ccd5e2..7c0046fd 100644 --- a/Library/RequestResponseHeaders.ts +++ b/Library/RequestResponseHeaders.ts @@ -23,13 +23,13 @@ export = { requestIdHeader: "request-id", /** - * Legacy Header containing the id of the immidiate caller + * Legacy Header containing the id of the immediate caller */ parentIdHeader: "x-ms-request-id", /** * Legacy Header containing the correlation id that kept the same for every telemetry item - * accross transactions + * across transactions */ rootIdHeader: "x-ms-request-root-id", diff --git a/Library/Sender.ts b/Library/Sender.ts index a930fc16..a8ca6068 100644 --- a/Library/Sender.ts +++ b/Library/Sender.ts @@ -19,7 +19,7 @@ class Sender { private static ACLED_DIRECTORIES: {[id: string]: boolean} = {}; private static ACL_IDENTITY: string = null; - // the amount of time the SDK will wait between resending cached data, this buffer is to avoid any throtelling from the service side + // the amount of time the SDK will wait between resending cached data, this buffer is to avoid any throttling from the service side public static WAIT_BETWEEN_RESEND = 60 * 1000; public static MAX_BYTES_ON_DISK = 50 * 1000 * 1000; public static MAX_CONNECTION_FAILURES_BEFORE_WARN = 5; @@ -396,7 +396,7 @@ class Sender { // This will create the dir if it does not exist // Default permissions on *nix are directory listing from other users but no file creations - Logging.info(Sender.TAG, "Checking existance of data storage directory: " + directory); + Logging.info(Sender.TAG, "Checking existence of data storage directory: " + directory); this._confirmDirExists(directory, (error) => { if (error) { Logging.warn(Sender.TAG, "Error while checking/creating directory: " + (error && error.message)); @@ -436,7 +436,7 @@ class Sender { var directory = path.join(os.tmpdir(), Sender.TEMPDIR_PREFIX + this._config.instrumentationKey); try { - Logging.info(Sender.TAG, "Checking existance of data storage directory: " + directory); + Logging.info(Sender.TAG, "Checking existence of data storage directory: " + directory); if (!fs.existsSync(directory)) { fs.mkdirSync(directory); } diff --git a/Schema/PublicSchema/ContextTagKeys.bond b/Schema/PublicSchema/ContextTagKeys.bond index 0a493716..531f277e 100644 --- a/Schema/PublicSchema/ContextTagKeys.bond +++ b/Schema/PublicSchema/ContextTagKeys.bond @@ -82,7 +82,7 @@ struct ContextTagKeys [MaxStringLength("256")] 705: string CloudRole = "ai.cloud.role"; - [Description("Name of the instance where the application is running. Computer name for on-premisis, instance name for Azure.")] + [Description("Name of the instance where the application is running. Computer name for on-premises, instance name for Azure.")] [MaxStringLength("256")] 715: string CloudRoleInstance = "ai.cloud.roleInstance"; diff --git a/Schema/PublicSchema/RemoteDependencyData.bond b/Schema/PublicSchema/RemoteDependencyData.bond index 6b3ab748..ba21cafc 100644 --- a/Schema/PublicSchema/RemoteDependencyData.bond +++ b/Schema/PublicSchema/RemoteDependencyData.bond @@ -26,7 +26,7 @@ struct RemoteDependencyData [ActAsRequired("Renaming value to duration.")] 61: required string duration; - [Description("Indication of successfull or unsuccessfull call.")] + [Description("Indication of successful or unsuccessful call.")] 120: nullable success = true; [MaxStringLength("8192")] diff --git a/Schema/PublicSchema/RequestData.bond b/Schema/PublicSchema/RequestData.bond index f26f9268..699a86cf 100644 --- a/Schema/PublicSchema/RequestData.bond +++ b/Schema/PublicSchema/RequestData.bond @@ -21,7 +21,7 @@ struct RequestData [Description("Result of a request execution. HTTP status code for HTTP requests.")] 60: required string responseCode; - [Description("Indication of successfull or unsuccessfull call.")] + [Description("Indication of successful or unsuccessful call.")] 70: required bool success; [MaxStringLength("1024")]