You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@v-kellyluo This does not reproduce for me at all using the same build or on our main branch. Clicking Add does require network communication. Perhaps there was a network issue? Does this still reproduce for you?
craxal
changed the title
It is always in a verified state when adding one custom environment if using 'https://maneg.com' as the ARM endpoint
It is always "Retrieving configuration..." when adding one custom environment if using 'https://maneg.com' as the ARM endpoint
Apr 26, 2024
There's a "TypeError: Converting circular structure to JSON" error getting thrown that isn't being caught.
Here's what I think is happening:
The management endpoint is passed to the function for adding custom environments.
The management is passed to the identity library which calls into a custom HTTP client to send a request for the management endpoint configuration.
Because the endpoint does not exist, the HTTP request throws an error.
The custom HTTP client handles errors by catching them, logging them, then rethrowing the error. The error is passed to our ExceptionSerializer.serialize() function. This, I think, is what is throwing, because it's trying to serialize a property (issuerCertificate) that isn't JSON-serializable (circular or self-referencing).
This is...a problem. I don't think we ever anticipated any error or error-like objects to contain circular references. We'll need to handle this somehow at some point.
To clarify, though, I do not believe this is a regression, as the circular references issue has always been there; it's just surfacing now, for some reason. Also, considering this only happens when the management endpoint doesn't exist, and we don't accept them until we've gotten positive confirmation that it does, I don't think a fix for this is urgent.
Storage Explorer Version: 1.34.0-dev (98)
Build Number: 20240425.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.4.1(Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: Ad-hoc testing
Regression From: Previous release (1.30.2)
Steps to Reproduce
Expected Experience
An error message appears.
Actual Experience
It is always in a verified state.
The text was updated successfully, but these errors were encountered: