Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'EXPLORER' panel is opened if close one split tab #7925

Open
v-xianya opened this issue May 9, 2024 · 2 comments
Open

The 'EXPLORER' panel is opened if close one split tab #7925

v-xianya opened this issue May 9, 2024 · 2 comments
Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing
Milestone

Comments

@v-xianya
Copy link
Member

v-xianya commented May 9, 2024

Storage Explorer Version: 1.34.0-dev (98)
Build Number: 20240508.1
Branch: rel/1.34.0
Platform/OS: Windows 10/Windows 11/Linux Ubuntu 22.04/MacOS Sonoma 14.4.1(Apple M1 Pro)
Architecture: x64/arm64/x64/arm64
How Found: Exploratory testing
Regression From: Previous release (1.33.1)

Steps to Reproduce

  1. Expand one storage account -> Blob Containers.
  2. Open one blob container -> Split the blob container tab.
  3. Toggle sidebar by pressing Ctrl+B or clicking the first icon on the vertical toolbar.
  4. Close one of the blob container tabs.
  5. Check whether the EXPLORER panel is not opened.

Expected Experience

The EXPLORER panel is not opened.

Actual Experience

The EXPLORER panel is opened.

Additional Context

If switch to 'ACCOUNT MANAGEMENT' panel -> then close one split tab -> It will navigate to 'EXPLORER' panel.

@v-xianya v-xianya added 🧪 testing Found through regular testing 🪲 regression Issue was working in a previous version labels May 9, 2024
@craxal
Copy link
Contributor

craxal commented May 9, 2024

This only happens if the last tab of a split panel is closed. The shell does not take into account that other tabs in other splits might be available to focus before focusing on the explorer panel.

Not the easiest fix, because the tab closing code is spread across several classes, and the code that adjusts focus isn't in a convenient spot. It's not a breaking change, and a subtle behavior, so I think this can wait till 1.35.0.

Bug was introduced here when fixing #7702: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/StorageExplorer/pullrequest/531330

@craxal craxal added this to the 1.35.0 milestone May 9, 2024
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.35.0, Near Future May 20, 2024
@MRayermannMSFT
Copy link
Member

Revsisit if a user complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing
Projects
None yet
Development

No branches or pull requests

3 participants