Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prop enterkeyhint for TextInput component #3762

Closed
bertrod opened this issue Feb 25, 2021 · 4 comments
Closed

Update prop enterkeyhint for TextInput component #3762

bertrod opened this issue Feb 25, 2021 · 4 comments
Assignees
@compulim
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report front-burner p1 Painful if we don't fix, won't block releasing
Projects
R14
Milestone
R14

Comments

@bertrod
Copy link

bertrod commented Feb 25, 2021

It seems the TextInput component is producing a warning when using the prop enterkeyhint for react >17. This is a known issue and it would be nice to get rid off the warning. It's just about updating the case of the prop to become enterKeyHint

necolas/react-native-web#1778
@v-kydela v-kydela added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Feb 25, 2021
@congysu
Copy link
Member

congysu commented Feb 25, 2021

@compulim could you please take a look at this? Thanks.

@compulim
Copy link
Contributor

compulim commented Mar 2, 2021

We need to find a solution for this.

In React 16.8.6 (which we use as base version), it use enterkeyhint and doesn't accept enterKeyHint.

In higher version of React 16, it use enterKeyHint and not accepting enterkeyhint.

@corinagum corinagum added this to R13 Candidates in R13 Mar 2, 2021
@corinagum corinagum added the customer-replied-to Required for internal reporting. Do not delete. label Mar 2, 2021
@corinagum
Copy link
Contributor

I have added this to our list of bugs for fix consideration during R13.

@corinagum corinagum added the bug Indicates an unexpected problem or an unintended behavior. label Mar 2, 2021
@corinagum corinagum added p1 Painful if we don't fix, won't block releasing backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner labels Mar 10, 2021
@carlosscastro carlosscastro added the ExemptFromDailyDRIReport exempt from daily DRI report label Mar 25, 2021
@corinagum corinagum added this to R14 Candidates in R14 Mar 30, 2021
@compulim compulim moved this from R14 Candidates to To do in R14 Apr 28, 2021
@compulim compulim added this to the R14 milestone May 17, 2021
@compulim compulim moved this from To do to In progress in R14 May 19, 2021
@compulim compulim moved this from In progress to To do in R14 May 19, 2021
@compulim compulim moved this from To do to In progress in R14 May 20, 2021
@compulim
Copy link
Contributor

This is already fixed in #3703 with the introduction of useEnterKeyHint hook.

R14 automation moved this from In progress to Done May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report front-burner p1 Painful if we don't fix, won't block releasing
Projects
R14
Done
Milestone
R14
Development

No branches or pull requests
6 participants
@compulim @congysu @bertrod @corinagum @carlosscastro @v-kydela