New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the code: CommandOutputReceiver #600

Open

hydraxman opened this issue Sep 16, 2023 · 1 comment

Assignees

Member

hydraxman commented Sep 16, 2023

Why it's using GBK as encoding? And the IO handling needs improvement.

And there are dup code in:

SmartTestLog
XCTestCommandReceiver

hydraxman assigned hydraxman and zhou9584 and unassigned hydraxman

Member Author

hydraxman commented Sep 17, 2023 •

edited

@zhou9584 please refer to this fix and pick it to the main branch, thanks: 9d369ae, 3d85bc4

You may create a PR for each above commit.

Some guidelines on picking a commit, you may do it leveraging the desktop app or git command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment