Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Win-Ctrl-Shift-M instead of Windows native shortcut Win-Shift-M for Screen Ruler #32623

Open
nx-frost opened this issue Apr 26, 2024 · 11 comments · May be fixed by #32732
Open

Prefer Win-Ctrl-Shift-M instead of Windows native shortcut Win-Shift-M for Screen Ruler #32623

nx-frost opened this issue Apr 26, 2024 · 11 comments · May be fixed by #32732
Assignees
@nx-frost
Labels
Idea-Enhancement New feature or request on an existing product Status-In progress This issue or work-item is under development

Comments

@nx-frost
Copy link

nx-frost commented Apr 26, 2024 •
edited

Description of the new feature / enhancement

The Screen Ruler will be bound to ⊞ Win-Ctrl-Shift-M by default.

Scenario when this would be used?

This would be useful to preserve the built-in Windows functionality which is otherwise not completely functional (desktop windows can be minimized but then cannot be restored). A user could still rebind to Win-Shift-M if they prefer.

Supporting information

When attempting to restore desktop windows minimized with the Windows built-in keyboard shortcut Win-M by using the built-in keyboard shortcut Win-Shift-M, the expected operating system functionality is overridden by the Screen Ruler.

Edit: The original proposal was to bind Ctrl-Shift-M by default, but I have changed this to ⊞ Win-Ctrl-Shift-M as it is more intuitive and similar to other PowerToys defaults and is less likely to conflict with third-party software.
@nx-frost nx-frost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 26, 2024
@Jay-o-Way
Copy link
Collaborator

Hello and thanks for your message. You can change the hotkey for most modules in PowerToys Settings. Including Ctrl+Shift+M for Screen Ruler.

@Jay-o-Way Jay-o-Way added Resolution-Helped User Could help the user by a problem they had and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 27, 2024
@Jay-o-Way
Copy link
Collaborator

@crutkas @ethanfangg Regarding the DEFAULT setting(s) - that's a valid point.

@nx-frost
Copy link
Author

@Jay-o-Way Thank you, but this was not a help issue; I am well aware I can rebind the keys. This is specifically about the defaults. Please remove the tag "Resolution-Helped User". Does this need to be resubmitted as a bug? It's not really a bug, hence why I put it as a feature request.

@Jay-o-Way Jay-o-Way added Idea-Enhancement New feature or request on an existing product and removed Resolution-Helped User Could help the user by a problem they had labels Apr 28, 2024
@ethanfangg
Copy link
Contributor

TIL Win+Shit+M reverts Win+M.

Ctrl+Shift+M also does something as well (not exactly sure what this is), but I could see the argument for a default shortcut change here.

Thoughts @crutas @jaimecbernardo ?

@Jay-o-Way
Copy link
Collaborator

Can't find a OS level function for Ctrl+Shift+M, so any existing functionality must be at app level.

@nx-frost
Copy link
Author

nx-frost commented Apr 30, 2024 •
edited

An alternative proposal is Win-Alt-M. There are lots of possible choices, and I can see why Ctrl-Shift-M may be less than ideal; other programs may also make use of it—it's also a shortcut on GitHub.

@jaimecbernardo
Copy link
Collaborator

@ethanfangg , On previous cases where the impact seem to have been minimal, we've let the shortcut stay, as users can change the shortcut through the settings.
Regarding using a new shortcut, I think we'd prefer to keep using the Windows key somewhere in the shortcut. So, perhaps "Win"+"Ctrl"+"Shift"+"M", if we end up doing it?

This was referenced May 5, 2024
Open
Open
@nx-frost nx-frost changed the title Prefer Ctrl-Shift-M instead of Windows native shortcut Win-Shift-M for Screen Ruler Prefer Win-Ctrl-Shift-M instead of Windows native shortcut Win-Shift-M for Screen Ruler May 5, 2024
@nx-frost
Copy link
Author

nx-frost commented May 5, 2024

I think that ⊞ Win-Ctrl-Shift-M would be a bit more intuitive for users who do not happen to recall the hotkey for the Screen Ruler, since other tools tend to make use of ⊞ Win, Ctrl and Shift but largely avoid Alt.

I have edited the original proposal to reflect my opinion, and I have submitted a draft PR.
If there are no qualms, it can go to review.

@Jay-o-Way Jay-o-Way added the Status-In progress This issue or work-item is under development label May 5, 2024
@nx-frost
Copy link
Author

nx-frost commented May 6, 2024

This is ready to go; please review at your convenience:

@Jay-o-Way
Copy link
Collaborator

@nx-frost thanks for your effort! Reviews (and such) may sometimes take time here. A little bit of patience is needed now and then.

@nx-frost
Copy link
Author

nx-frost commented May 6, 2024

For sure, just wanted to ensure there is no further action required on my part. That'll be all from me. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nx-frost nx-frost

Labels
Idea-Enhancement New feature or request on an existing product Status-In progress This issue or work-item is under development
Projects
Test for PowerToys
Status: In Progress ⚒️
Milestone
No milestone
4 participants
@nx-frost @jaimecbernardo @Jay-o-Way @ethanfangg