From 0487b38d06593b06fa30555c3dcf888063ad7369 Mon Sep 17 00:00:00 2001 From: Kunal Desai Date: Mon, 12 Apr 2021 03:43:47 -0700 Subject: [PATCH] Catch hover on as const (#43588) * Catch hover on as const * Update test based on feedback --- src/services/services.ts | 2 +- tests/cases/fourslash/quickInfoForConstTypeReference.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/quickInfoForConstTypeReference.ts diff --git a/src/services/services.ts b/src/services/services.ts index bd5ba0421c27b..160c97e81e1e3 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -1670,7 +1670,7 @@ namespace ts { function shouldGetType(sourceFile: SourceFile, node: Node, position: number): boolean { switch (node.kind) { case SyntaxKind.Identifier: - return !isLabelName(node) && !isTagName(node); + return !isLabelName(node) && !isTagName(node) && !isConstTypeReference(node.parent); case SyntaxKind.PropertyAccessExpression: case SyntaxKind.QualifiedName: // Don't return quickInfo if inside the comment in `a/**/.b` diff --git a/tests/cases/fourslash/quickInfoForConstTypeReference.ts b/tests/cases/fourslash/quickInfoForConstTypeReference.ts new file mode 100644 index 0000000000000..4eb405bdc90e0 --- /dev/null +++ b/tests/cases/fourslash/quickInfoForConstTypeReference.ts @@ -0,0 +1,5 @@ +/// + +////"" as /**/const; + +verify.not.quickInfoExists(); \ No newline at end of file