From dc7e5a738a88f1dd72391d388d982df6ef082e90 Mon Sep 17 00:00:00 2001 From: TypeScript Bot Date: Wed, 5 Apr 2023 13:39:54 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20Pick=20PR=20#53599=20(Ignore=20`?= =?UTF-8?q?allowImportingTsExtensions`...)=20into=20release-5.0=20(#53600)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Andrew Branch --- src/compiler/commandLineParser.ts | 1 + src/testRunner/unittests/services/transpile.ts | 14 ++++++++++++++ ...ns without error (verbatimModuleSyntax=true).js | 2 ++ ...ror (verbatimModuleSyntax=true).oldTranspile.js | 2 ++ .../Can transpile .ts extensions without error.js | 2 ++ ...le .ts extensions without error.oldTranspile.js | 2 ++ ...out noEmit error (verbatimModuleSyntax=true).js | 2 ++ ...ror (verbatimModuleSyntax=true).oldTranspile.js | 2 ++ ...owImportingTsExtensions without noEmit error.js | 2 ++ ...Extensions without noEmit error.oldTranspile.js | 2 ++ 10 files changed, 31 insertions(+) create mode 100644 tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).js create mode 100644 tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).oldTranspile.js create mode 100644 tests/baselines/reference/transpile/Can transpile .ts extensions without error.js create mode 100644 tests/baselines/reference/transpile/Can transpile .ts extensions without error.oldTranspile.js create mode 100644 tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).js create mode 100644 tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).oldTranspile.js create mode 100644 tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.js create mode 100644 tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.oldTranspile.js diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts index 629063de29808..b88f6325ba0af 100644 --- a/src/compiler/commandLineParser.ts +++ b/src/compiler/commandLineParser.ts @@ -1104,6 +1104,7 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [ category: Diagnostics.Modules, description: Diagnostics.Allow_imports_to_include_TypeScript_file_extensions_Requires_moduleResolution_bundler_and_either_noEmit_or_emitDeclarationOnly_to_be_set, defaultValueDescription: false, + transpileOptionValue: undefined, }, { name: "resolvePackageJsonExports", diff --git a/src/testRunner/unittests/services/transpile.ts b/src/testRunner/unittests/services/transpile.ts index f20efec044f93..b9f8bc915eca2 100644 --- a/src/testRunner/unittests/services/transpile.ts +++ b/src/testRunner/unittests/services/transpile.ts @@ -606,4 +606,18 @@ export * as alias from './file';`, { testVerbatimModuleSyntax: "only" } ); + + transpilesCorrectly("Can transpile .ts extensions without error", + `import { foo } from "./foo.ts";`, { + options: { compilerOptions: { module: ts.ModuleKind.ESNext, target: ts.ScriptTarget.ESNext } }, + testVerbatimModuleSyntax: true + } + ); + + transpilesCorrectly("Ignores `allowImportingTsExtensions` without `noEmit` error", + `import { foo } from "./foo.ts";`, { + options: { compilerOptions: { module: ts.ModuleKind.ESNext, allowImportingTsExtensions: true, target: ts.ScriptTarget.ESNext } }, + testVerbatimModuleSyntax: true + } + ); }); diff --git a/tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).js b/tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).js new file mode 100644 index 0000000000000..9a1ba82b5b69f --- /dev/null +++ b/tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).js @@ -0,0 +1,2 @@ +import { foo } from "./foo.ts"; +//# sourceMappingURL=file.js.map \ No newline at end of file diff --git a/tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).oldTranspile.js b/tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).oldTranspile.js new file mode 100644 index 0000000000000..9a1ba82b5b69f --- /dev/null +++ b/tests/baselines/reference/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).oldTranspile.js @@ -0,0 +1,2 @@ +import { foo } from "./foo.ts"; +//# sourceMappingURL=file.js.map \ No newline at end of file diff --git a/tests/baselines/reference/transpile/Can transpile .ts extensions without error.js b/tests/baselines/reference/transpile/Can transpile .ts extensions without error.js new file mode 100644 index 0000000000000..e113dbc728253 --- /dev/null +++ b/tests/baselines/reference/transpile/Can transpile .ts extensions without error.js @@ -0,0 +1,2 @@ +export {}; +//# sourceMappingURL=file.js.map \ No newline at end of file diff --git a/tests/baselines/reference/transpile/Can transpile .ts extensions without error.oldTranspile.js b/tests/baselines/reference/transpile/Can transpile .ts extensions without error.oldTranspile.js new file mode 100644 index 0000000000000..e113dbc728253 --- /dev/null +++ b/tests/baselines/reference/transpile/Can transpile .ts extensions without error.oldTranspile.js @@ -0,0 +1,2 @@ +export {}; +//# sourceMappingURL=file.js.map \ No newline at end of file diff --git a/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).js b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).js new file mode 100644 index 0000000000000..9a1ba82b5b69f --- /dev/null +++ b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).js @@ -0,0 +1,2 @@ +import { foo } from "./foo.ts"; +//# sourceMappingURL=file.js.map \ No newline at end of file diff --git a/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).oldTranspile.js b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).oldTranspile.js new file mode 100644 index 0000000000000..9a1ba82b5b69f --- /dev/null +++ b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).oldTranspile.js @@ -0,0 +1,2 @@ +import { foo } from "./foo.ts"; +//# sourceMappingURL=file.js.map \ No newline at end of file diff --git a/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.js b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.js new file mode 100644 index 0000000000000..e113dbc728253 --- /dev/null +++ b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.js @@ -0,0 +1,2 @@ +export {}; +//# sourceMappingURL=file.js.map \ No newline at end of file diff --git a/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.oldTranspile.js b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.oldTranspile.js new file mode 100644 index 0000000000000..e113dbc728253 --- /dev/null +++ b/tests/baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.oldTranspile.js @@ -0,0 +1,2 @@ +export {}; +//# sourceMappingURL=file.js.map \ No newline at end of file