diff --git a/src/compiler/program.ts b/src/compiler/program.ts index 9b3014390a330..6b8f56d1daf35 100644 --- a/src/compiler/program.ts +++ b/src/compiler/program.ts @@ -2707,10 +2707,6 @@ namespace ts { createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_with_option_1, getEmitDeclarationOptionName(options), "isolatedModules"); } - if (options.noEmitOnError) { - createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_with_option_1, "noEmitOnError", "isolatedModules"); - } - if (options.out) { createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_with_option_1, "out", "isolatedModules"); } diff --git a/tests/baselines/reference/isolatedModulesNoEmitOnError.errors.txt b/tests/baselines/reference/isolatedModulesNoEmitOnError.errors.txt index 34ff251c16701..2ddfa178de239 100644 --- a/tests/baselines/reference/isolatedModulesNoEmitOnError.errors.txt +++ b/tests/baselines/reference/isolatedModulesNoEmitOnError.errors.txt @@ -1,6 +1,7 @@ -error TS5053: Option 'noEmitOnError' cannot be specified with option 'isolatedModules'. +tests/cases/compiler/file1.ts(1,14): error TS2322: Type '3' is not assignable to type 'string'. -!!! error TS5053: Option 'noEmitOnError' cannot be specified with option 'isolatedModules'. -==== tests/cases/compiler/file1.ts (0 errors) ==== - export var x; \ No newline at end of file +==== tests/cases/compiler/file1.ts (1 errors) ==== + export const x: string = 3; + ~ +!!! error TS2322: Type '3' is not assignable to type 'string'. \ No newline at end of file diff --git a/tests/baselines/reference/isolatedModulesNoEmitOnError.symbols b/tests/baselines/reference/isolatedModulesNoEmitOnError.symbols index 625dbfbe699b8..67306c205a7ea 100644 --- a/tests/baselines/reference/isolatedModulesNoEmitOnError.symbols +++ b/tests/baselines/reference/isolatedModulesNoEmitOnError.symbols @@ -1,4 +1,4 @@ === tests/cases/compiler/file1.ts === -export var x; ->x : Symbol(x, Decl(file1.ts, 0, 10)) +export const x: string = 3; +>x : Symbol(x, Decl(file1.ts, 0, 12)) diff --git a/tests/baselines/reference/isolatedModulesNoEmitOnError.types b/tests/baselines/reference/isolatedModulesNoEmitOnError.types index 27dca700bb904..3a4f55b925cba 100644 --- a/tests/baselines/reference/isolatedModulesNoEmitOnError.types +++ b/tests/baselines/reference/isolatedModulesNoEmitOnError.types @@ -1,4 +1,5 @@ === tests/cases/compiler/file1.ts === -export var x; ->x : any +export const x: string = 3; +>x : string +>3 : 3 diff --git a/tests/cases/compiler/isolatedModulesNoEmitOnError.ts b/tests/cases/compiler/isolatedModulesNoEmitOnError.ts index ce3085dbc3b9f..46ab4efcb089c 100644 --- a/tests/cases/compiler/isolatedModulesNoEmitOnError.ts +++ b/tests/cases/compiler/isolatedModulesNoEmitOnError.ts @@ -3,4 +3,4 @@ // @target: es6 // @filename: file1.ts -export var x; \ No newline at end of file +export const x: string = 3; \ No newline at end of file