Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript version 2.1.0-dev.20161025 has require regression #11834

Closed
johnnyreilly opened this issue Oct 25, 2016 · 2 comments
Closed

Typescript version 2.1.0-dev.20161025 has require regression #11834

johnnyreilly opened this issue Oct 25, 2016 · 2 comments
Labels
Question An issue which isn't directly actionable in code

Comments

@johnnyreilly
Copy link

johnnyreilly commented Oct 25, 2016

Hi,

I'm a maintainer of ts-loader for Webpack. We've just noticed that out simpleDependency test has started failing consistently on Windows and Linux

TypeScript Version: 2.0.3 / nightly (2.1.0-dev.20161025)

Code

Take a look here for the PR on which I noticed the issue: TypeStrong/ts-loader#337

And look here for the Karma test that demostrates the issue: https://github.com/TypeStrong/ts-loader/tree/master/test/execution-tests/simpleDependency

Expected behavior:

Test passes with TypeScript@latest (as with TS 1.6 - 2.0)

Actual behavior:

Test fails with TypeScript@latest (despite passing for other versions of TS)

@mhegazy
Copy link
Contributor

mhegazy commented Oct 25, 2016

In https://github.com/TypeStrong/ts-loader/blob/master/test/execution-tests/simpleDependency/tsconfig.json#L4 the files list is empty. this means no files are consumed by the compiler.

In past versions the compiler silently finished with a non-error return code (as there is no work to be done). This has been confusing to users who wounder why output files were not generated (see #11621 and #11156).

In #11743 we made this an error, so that users are aware that the compilation they ran was a no op.

@johnnyreilly
Copy link
Author

Ah - I see. Thanks. I'll fix up our test pack to cater for that. I've just realised that this creates a small problem for ts-loader with regards our instance test. i.e. ts-loader was relying on the noop to not error. Now it will; I think we already have an issue raised around this:

TypeStrong/ts-loader#268

and possibly related:

TypeStrong/ts-loader#267

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Question An issue which isn't directly actionable in code
Projects
None yet
Development

No branches or pull requests

3 participants