Large composite project crashes tsserver.js with "Debug Failure. False expression." #26546
Comments
|
@leemhenson we'll likely need a lot more information to be able to fix this; call stacks alone aren't enough for us to root-cause this particular kind of bug. Is there a repo we can look at? |
RyanCavanaugh
added
the
Needs More Info
|
Also apart from that you should submit tsserver log to be able to understand the issue.
|
|
A smidge more data: @sheetalkamat @RyanCavanaugh This project is private so I can't share it, and as you can see from the diagnostics it's pretty big! If the data in the uploaded log files isn't enough to figure out the issue I'll try to recreate it on a smaller scale. |
|
@leemhenson From the shared log, nothing stood out. From the log it seems project has 1343 files being added to it (compared to tsc 934 as per your shared data) That's the only thing standing out as such. We would need repro to investigate this and tsserver log is not enough. |
|
@leemhenson One option would be for us to sign an NDA, if that would allow us to look at your original code. |
|
I'm a bit snowed under at the moment but I'll try to work up a repro. If not I'll see about the NDA route. |
|
I am also having this problem on a similar project. It's private as well but I'd be more than willing to provide access to the project. |
|
@drew-y Thanks! I'll contact you over e-mail to talk about how to get access. |
DanielRosenwasser
added
the
Crash
|
I have also run into this on a large composite project. The build will work fine one minute then it will get into this state, and reverting my most recent change doesn't restore the build. I will put together a repro case as soon as possible. In the meantime, I have been able to work around it by doing a clean (removing existing build artifacts) and building again. If that is the case for the OP, it may be a clue. In any case, it may help others hitting this. |
RyanCavanaugh
removed
the
Needs More Info
|
Here's a 100% repro w/two .ts and three tsconfig files running tsc version 3.4.5. Cmdline: "tsc --build src" |
|
Looking back at my e-mail, @drew-y's problem was fixed in 3.1.4. It's just @leemhenson's bug that is outstanding. I could be wrong, though, and maybe the code did exist already, so it could in fact be the same issue that @wolcotts saw. @leemhenson can you test with typescript@next or typescript@rc? |
|
Hey @sandersn, I no longer work at that company so don't have access to that project to test. I'm 99% certain it's the same problem I reported here: I just updated the repro project listed there to |
|
Thanks. You've done a lot of work on this one. I'll close this as a duplicate of #30429 since it looks like the oomemory is the blocker now, not the mergeSymbol assertion. |
|
we just got bitten by this very issue when we tried to switch to composite builds |
|
@zpdDG4gta8XKpMCd Which issue? An assert with a stack ending in mergeSymbol? Or does the build run out of memory? |
|
build runs out of memory, no matter how much we give it via |
TypeScript Version: 3.1.0-dev.20180818
Search Terms: Debug Failure False Expression
Code
My project contains a single package which is built from:
Each directory under
srchas it's own composite tsconfig.json, and they form a DAG. There is also a tsconfig underteststhat references each and every directory undersrc. The root directory contains a tsconfig that references every tsconfig undersrcandtests.Expected behavior:
tsc --buildshould succeed and I should be able to browse the code in vscode without issue.Actual behavior:
tsc --buildsucceeds, and I can browse code undersrcin vscode without issue. However, when I open up a file insidetests, the following error is emitted in the tsserver.log:The typescript process is then dead on that file, not even a
Loading...hover. The following process in process explorer seems to be stuck:The text was updated successfully, but these errors were encountered: