Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow in isExportsOrModuleExportsOrAlias #31080

Closed
amcasey opened this issue Apr 23, 2019 · 3 comments
Closed

Stack overflow in isExportsOrModuleExportsOrAlias #31080

amcasey opened this issue Apr 23, 2019 · 3 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@amcasey
Copy link
Member

amcasey commented Apr 23, 2019

Originally reported on Developer Community: https://developercommunity.visualstudio.com/content/problem/529989/aspnet-在html-文件-js-智能提示失效.html

Stack cycle is

at isExportsOrModuleExportsOrAlias (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:29774:38)
at isExportsOrModuleExportsOrAliasOrAssignment (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:29783:16)
at isNameOfExportsOrModuleExportsAliasDeclaration (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:29780:54)
at isExportsOrModuleExportsOrAlias (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:29774:38)

TS version is 3.3.3.

I looked at the code and didn't see an obvious cycle (unless a node is somehow its own initializer), so I'm guessing it was just a deep stack of nested initializers.

I didn't see a recent change in this area or a but with these stack frames.

@amcasey amcasey added the Bug A bug in TypeScript label Apr 23, 2019
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.6.0 milestone Jun 12, 2019
@rbuckton
Copy link
Member

It could be that this is where the stack terminates, but isn't itself cyclical. Is there more context? I cannot seem to see where you found the stack trace.

@rbuckton
Copy link
Member

It looks like this has already been fixed.

@rbuckton
Copy link
Member

This was fixed by #31436

@rbuckton rbuckton added the Fixed A PR has been merged for this issue label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

4 participants