Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean as a type guard #31164

Closed
5 tasks done
pelotom opened this issue Apr 29, 2019 · 3 comments
Closed
5 tasks done

Boolean as a type guard #31164

pelotom opened this issue Apr 29, 2019 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@pelotom
Copy link

pelotom commented Apr 29, 2019

Search Terms

boolean type guard

Suggestion

A common idiom in JavaScript is to filter an array using Boolean as a filter function to remove falsy values. To make this useful in TypeScript, Boolean should act as a type guard:

+type Falsy = false | 0 | '' | null | undefined;

interface BooleanConstructor {
  new (value?: any): Boolean;
- (value?: any): boolean;
+ <A>(value: A | Falsy): x is A;
  readonly prototype: Boolean;
}

Examples

// The type of `numbers` should be `number[]` but currently it is `(number | undefined)[]`.
const numbers = [1, 2, undefined, 3].filter(Boolean);

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code (I think this is true?)
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.
@DanielRosenwasser
Copy link
Member

Related to #24063.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Apr 29, 2019

And related to #16655.

@jack-williams
Copy link
Collaborator

Think this is implemented by #29955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

4 participants