Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Did you mean 'get'/'set'?" errors have issues #34884

Closed
DanielRosenwasser opened this issue Nov 2, 2019 · 0 comments · Fixed by #34885
Closed

"Did you mean 'get'/'set'?" errors have issues #34884

DanielRosenwasser opened this issue Nov 2, 2019 · 0 comments · Fixed by #34885
Assignees
@DanielRosenwasser
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue
Milestone
TypeScript 3.8.0

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Nov 2, 2019 •
edited

Follow-up from #26098 (PR at #26446)

Current logic:

  • Doesn't ever suggest the identifier/property access in the message (this was requested)
  • Only works when the arity of a set is 1 (means it actually doesn't work with Maps)
  • Only works when the parameter type's string representation is string.

Each of these is a bug.
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging labels Nov 2, 2019
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.8.0 milestone Nov 2, 2019
@DanielRosenwasser DanielRosenwasser self-assigned this Nov 2, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue Nov 2, 2019
Merged
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 3.8.0
Development

Successfully merging a pull request may close this issue.

Fix check for get/set recommendation microsoft/TypeScript
1 participant
@DanielRosenwasser