Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disablePictureInPicture property to HTML5 Video Elements #36324

Closed
5 tasks done
eek opened this issue Jan 21, 2020 · 2 comments
Closed
5 tasks done

Add disablePictureInPicture property to HTML5 Video Elements #36324

eek opened this issue Jan 21, 2020 · 2 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript
Milestone

Comments

@eek
Copy link

eek commented Jan 21, 2020

Search Terms

disablePictureInPicture, "picture-in-picture"

Suggestion

Add suppport for disablePictureInPicture on HTML5 Video Elements.

Use Cases & Examples

Remove More Button on Video Elements and not give an error.

Examples of usage for the property:

facebook/react#15333

Currently it give the error:

TS2339 Property 'disablePictureInPicture' does not exist on HTML5VideoElement.

Which is supported in all Chromium-based browsers (by adding this tag to the HTML5 Video Element, you remove the Picture in Picture option from the Video Element's Menu.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.
@MartinJohns
Copy link
Contributor

Should experimental features really be added to the default library?

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Jan 23, 2020
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Jan 23, 2020
@jakebailey
Copy link
Member

This was fixed in #44684.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants