Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated lib*.d.ts files differ from the files in TypeScript SDK #41597

Closed
deniskovalchuk opened this issue Nov 19, 2020 · 2 comments
Closed
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this
Milestone

Comments

@deniskovalchuk
Copy link

TypeScript Version: at least 3.9.7 and 4.0.5

The lib/lib*.d.ts and built/local/lib*.d.ts files contain mixed line breaks (LF/CRLF) and differ from the files in the TypeScript SDK, which contain only LF.

Steps to reproduce

Build LKG or local on any operating system.

git clone --config core.autocrlf=input https://github.com/microsoft/TypeScript.git
cd TypeScript
npm ci
gulp LKG

Expected behavior:

Consistent line breaks in lib*.d.ts files and no differences from the TypeScript SDK.

Actual behavior:

Mixed line breaks.

actual-line-breaks

@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Nov 20, 2020
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Nov 20, 2020
@DanielRosenwasser DanielRosenwasser added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". labels Nov 20, 2020
@jakebailey
Copy link
Member

jakebailey commented Jul 5, 2023

Post #51387, this one is definitely fixed as the problem here was the way we combined things with gulp (among other things). In the new build, the entirety of built and lib now consistently use LF line endings.

@deniskovalchuk
Copy link
Author

deniskovalchuk commented Jul 6, 2023

@jakebailey, I've tested TypeScript 5.1.6 and can confirm that this problem has been fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

4 participants