Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Unicode string imports and exports #43870

Closed
DanielRosenwasser opened this issue Apr 28, 2021 · 3 comments
Closed

Allow Unicode string imports and exports #43870

DanielRosenwasser opened this issue Apr 28, 2021 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Apr 28, 2021

tc39/ecma262#2154

import { "😊" as yay } from "...";

yay();

export { yay as "🦈" };

The above code should be supported.

The minimum viable product should have tests for:

  • esnext module output
  • es2015 or similar module output just to get an error
  • --declaration emit
    • Specific declaration emit where the compiler might generate import() type syntax.
  • Quick info, and error message tests where we might generate import() type syntax
  • Completions in import {} and export {} lists
  • Go-to-definition

It is likely that we would never try to emit our own import() type syntax.

@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript Committed The team has roadmapped this issue ES Next New featurers for ECMAScript (a.k.a. ESNext) Domain: ES Modules The issue relates to import/export style module behavior labels Apr 28, 2021
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.4.0 milestone Apr 28, 2021
@Kingwl
Copy link
Contributor

Kingwl commented Apr 30, 2021

I’m happy to work on this (If @weswigham does not started)

@weswigham
Copy link
Member

weswigham commented Apr 30, 2021

I have not, and probably wouldn't until after the RC cut. If you do work on it, just keep in mind that something like #40708 we intend as a followup for this change, rather than a part of it. For this, we just wanna get the new syntax down, without expanding any TS syntax yet.

@ExE-Boss
Copy link
Contributor

ExE-Boss commented May 8, 2021

Duplicate of #40594

@DanielRosenwasser DanielRosenwasser added Duplicate An existing issue was already created and removed Committed The team has roadmapped this issue Domain: ES Modules The issue relates to import/export style module behavior ES Next New featurers for ECMAScript (a.k.a. ESNext) Suggestion An idea for TypeScript labels May 9, 2021
@DanielRosenwasser DanielRosenwasser removed this from the TypeScript 4.4.0 milestone May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

4 participants