Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please share large source lines when possible #45849

Closed
SnarkBoojum opened this issue Sep 13, 2021 · 3 comments
Closed

Please share large source lines when possible #45849

SnarkBoojum opened this issue Sep 13, 2021 · 3 comments
Labels
Unactionable There isn't something we can do with this issue

Comments

@SnarkBoojum
Copy link

While packaging 4.4.3 for Debian, the tools complained:

E: node-typescript source: source-is-missing lib/tsc.js line 100216 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/tsserver.js line 148247 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/tsserverlibrary.js line 147421 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/typescript.js line 138426 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/typescriptServices.js line 138426 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/typingsInstaller.js line 103440 is 9536 characters long (>512)

and in fact, the problem is with unicodeES3Identifier* variables: it is legitimate source code, but indeed looks suspicious.

I suggest to share those variables instead of copying them in several source files: that will be much safer in the long run.

@MartinJohns
Copy link
Contributor

It sounds like a duplicate of #35210 / #35561.

@SnarkBoojum
Copy link
Author

No, it's not really a duplicate. Modularizing would probably (but not surely) solve it, but it's not quite the same.

@MartinJohns
Copy link
Contributor

MartinJohns commented Sep 13, 2021

Then I'm not sure what your issue is. Values in the .js files can't be shared, because the compiler is not modularized - every .js file is running independently. Your issue is quite brief on the details and does not follow the issue template, so it's quite hard to make out what you actually want.

@andrewbranch andrewbranch added the Unactionable There isn't something we can do with this issue label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unactionable There isn't something we can do with this issue
Projects
None yet
Development

No branches or pull requests

3 participants