Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys.readFile for Node.js: the encoding parameter is ignored, so charset compiler option is ignored on Node.js #4718

Closed
denvned opened this issue Sep 10, 2015 · 4 comments
Closed

sys.readFile for Node.js: the encoding parameter is ignored, so charset compiler option is ignored on Node.js #4718

denvned opened this issue Sep 10, 2015 · 4 comments
Labels
Bug A bug in TypeScript Help Wanted You can do this
Milestone
Backlog

Comments

@denvned
Copy link
Contributor

denvned commented Sep 10, 2015

Current implementation of sys.readFile for Node.js ignore the encoding parameter. This effectively makes the charset compiler option ignored on Node.js. If it is "by desing", then it probably should be documented.
@mhegazy
Copy link
Contributor

mhegazy commented Sep 10, 2015

it is by design. the encoding is an option for engines that support it. node's read file does not support the whole encoding ranges. What sort of documentation you want? just a comment in the code, or an error message that this compiler option is not supported on this engine?

@denvned
Copy link
Contributor Author

denvned commented Sep 10, 2015

At least here I think. An error message and a description in the help output would be nice also. But this all is not so critical for me. Probably I will send a PR later.

@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this labels Sep 10, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Sep 10, 2015

A PR would definitely be appreciated!

@mhegazy mhegazy added this to the Community milestone Sep 18, 2015
@zhengbli zhengbli mentioned this issue Oct 27, 2016
Closed
@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
@jakebailey
Copy link
Member

charset was removed in #57527.

@jakebailey jakebailey closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@denvned @jakebailey @RyanCavanaugh @mhegazy