Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 4.5+: typescript.d.ts is missing new moduleResolution values #47987

Closed
frank-dspeed opened this issue Feb 21, 2022 · 6 comments
Closed
Labels
External Relates to another program, environment, or user action which we cannot control.

Comments

@frank-dspeed
Copy link

frank-dspeed commented Feb 21, 2022

lib Update Request

https://github.com/microsoft/TypeScript/blob/main/lib/typescript.d.ts is missing "node12" "nodenext"

Configuration Check

My compilation target is ES2015 and my lib is the default.

Missing / Incorrect Definition

https://github.com/microsoft/TypeScript/blob/main/lib/typescript.d.ts is missing moduleResolution: "node12" "nodenext"

Sample Code

tsconfig.json

{ 
"compilerOptions": { 
  moduleResolution: "node12"
 }
}

Documentation Link

https://www.typescriptlang.org/tsconfig#moduleResolution

Related

@MartinJohns
Copy link
Contributor

What version are you running? This feature is currently only available in the nightly version. #46454

@frank-dspeed
Copy link
Author

frank-dspeed commented Feb 22, 2022

@MartinJohns i am using the nightly typescript marketplace extension of typescript because i am from the nodejs package maintainance group and i want to prepare upgrades for the most essential community modules.

things like new resolve algos always deserve the full attention.

@IllusionMH
Copy link
Contributor

IllusionMH commented Feb 22, 2022

Do you mean this message?
image
This one is regular JSON Schema validation error as nightly values aren't added to Schema Store
https://github.com/SchemaStore/schemastore/blob/065f36c63001253df25baf31406eaa9c644b49be/src/schemas/json/tsconfig.json#L315-L331

JS/TS should work with this value as expected.

@frank-dspeed
Copy link
Author

frank-dspeed commented Feb 22, 2022

@IllusionMH your 100% correct and yes it works but it shows the info in the tsconfig

@RyanCavanaugh RyanCavanaugh added the External Relates to another program, environment, or user action which we cannot control. label Feb 23, 2022
@typescript-bot
Copy link
Collaborator

This issue has been marked as 'External' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

@frank-dspeed
Copy link
Author

@RyanCavanaugh please reopen and see SchemaStore/schemastore#2100

this issue gets internal as we need to use the external schemastore method to supply the spec https://raw.githubusercontent.com/ory/hydra/master/.schema/version.schema.json this is a example i can handle that for you but it is a internal issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Relates to another program, environment, or user action which we cannot control.
Projects
None yet
Development

No branches or pull requests

5 participants