New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Regression in Compilers-Unions #50360
Comments
I think you can just fix this if you check whether the target has the appropriate primitive-like flag for the literals you're checking. But I'm not sure. |
I don’t quite understand—the target is always a weak object type here, never a primitive. |
Hm - is it possible that it has to do with the use of I'm not that familiar with the weak type checking logic to be honest though, and maybe it'd be better to profile it. |
So, my assumption was that the perf impact was more likely to be due to actually performing more common-property checks, but the condition |
That's surprising. You don't really need to cache though because you'll re-enter the same branch where |
Let's see if #50423 fixes this. |
Our perf dashboard has a ~230ms regression on the compilers-unions benchmark starting at 4e33e0e introduced in #49865.
The text was updated successfully, but these errors were encountered: