Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

according to DOM specs cancelBubble is a legacy alias of .stopPropagation() #50517

Closed
Ahmed-Hakeem opened this issue Aug 29, 2022 · 4 comments
Closed

according to DOM specs cancelBubble is a legacy alias of .stopPropagation() #50517

Ahmed-Hakeem opened this issue Aug 29, 2022 · 4 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript
Milestone
Backlog

Comments

@Ahmed-Hakeem
Copy link

Ahmed-Hakeem commented Aug 29, 2022 •
edited

lib Update Request

Missing / Incorrect Definition

according to DOM spec cancelBubble is a legacy alias of .stopPropagation()

Documentation Link

https://dom.spec.whatwg.org/#interface-event

Reference

microsoft/TypeScript-DOM-lib-generator#1384
@fatcerberus
Copy link

fatcerberus commented Aug 29, 2022 •
edited

Not only deprecated, but also according to MDN, on Chromium-based browsers:

Starting with Chrome 58 and Opera 45, setting this property to false does nothing, as per spec discussion.

@MartinJohns
Copy link
Contributor

Needs to be fixed in https://github.com/microsoft/TypeScript-DOM-lib-generator. Modifying generated files as you did in your MR won't do it.

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Aug 29, 2022
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Aug 29, 2022
@Ahmed-Hakeem Ahmed-Hakeem mentioned this issue Aug 29, 2022
Closed
@Ahmed-Hakeem
Copy link
Author

Ahmed-Hakeem commented Oct 21, 2022 •
edited

Fixed in microsoft/TypeScript-DOM-lib-generator#1394 @RyanCavanaugh

@jakebailey
Copy link
Member

This was fixed in #50884.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@fatcerberus @MartinJohns @jakebailey @RyanCavanaugh @Ahmed-Hakeem