Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate inference changes in reselect due to tuple type mapping changes #50870

Closed
DanielRosenwasser opened this issue Sep 21, 2022 · 3 comments
Closed

Evaluate inference changes in reselect due to tuple type mapping changes #50870

DanielRosenwasser opened this issue Sep 21, 2022 · 3 comments
Assignees
@DanielRosenwasser @ahejlsberg
Labels
Needs Investigation This issue needs a team member to investigate its status. Needs More Info The issue still hasn't been fully clarified Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented.

Comments

@DanielRosenwasser
Copy link
Member

In #50831, we fixed a bug around ensuring that optional tuple elements always contain a missing/undefined type, even when a mapped type tries to remove them.

However, this had some impact on 2 calls to reduxjs/reselect. Occasionally undefined can spoil inference results, but it's not clear where that might be taking place in the library.
@DanielRosenwasser DanielRosenwasser added Needs More Info The issue still hasn't been fully clarified Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Needs Investigation This issue needs a team member to investigate its status. labels Sep 21, 2022
@markerikson markerikson mentioned this issue Sep 21, 2022
Closed
@ahejlsberg
Copy link
Member

See here for a simplified version of the MergeParameters type that works with TS 4.7 and later.

@RyanCavanaugh RyanCavanaugh mentioned this issue Oct 11, 2022
Closed
@markerikson
Copy link

FYI I was able to successfully use the MergeParameters type from Anders, although the publishing step to make the package work from 4.2...4.9 was awkward:

reduxjs/reselect#587

@Andarist
Copy link
Contributor

This investigation was resolved. reselect shipped the type provided by Anders. I think that this issue could be closed now :) cc @jakebailey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

@ahejlsberg ahejlsberg

Labels
Needs Investigation This issue needs a team member to investigate its status. Needs More Info The issue still hasn't been fully clarified Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DanielRosenwasser @markerikson @ahejlsberg @jakebailey @Andarist