Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewErrors] 4.9.0-dev.20220927 vs 4.8.4 #50979

Closed
typescript-bot opened this issue Sep 28, 2022 · 17 comments
Closed

[NewErrors] 4.9.0-dev.20220927 vs 4.8.4 #50979

typescript-bot opened this issue Sep 28, 2022 · 17 comments

Comments

@typescript-bot
Copy link
Collaborator

The following errors were reported by 4.9.0-dev.20220927, but not by 4.8.4
Pipeline that generated this bug
Logs for the pipeline run
File that generated the pipeline

This run considered 200 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 107 of 200 visited repos
Outcome Count
Detected interesting changes 16
Detected no interesting changes 91
Git clone failed 2
Package install failed 50
Too many errors in old TS 39
Unknown failure 2
@typescript-bot
Copy link
Collaborator Author

ant-design/ant-design

tsconfig.json

  • error TS2352: Conversion of type '{ pagination: true; }' to type 'TableProps<any>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

@typescript-bot
Copy link
Collaborator Author

codex-team/editor.js

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.build.json

@typescript-bot
Copy link
Collaborator Author

darkreader/darkreader

1 of 6 projects failed to build with the old tsc and were ignored

src/api/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

src/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

tests/inject/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

tests/unit/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

@typescript-bot
Copy link
Collaborator Author

Eugeny/tabby

10 of 29 projects failed to build with the old tsc and were ignored

tabby-community-color-schemes/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-electron/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-local/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-serial/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-ssh/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-telnet/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-terminal/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-terminal/tsconfig.typings.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-web-demo/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

@typescript-bot
Copy link
Collaborator Author

graphql/graphql-js

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

JedWatson/react-select

3 of 5 projects failed to build with the old tsc and were ignored

packages/react-select/src/tests/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

jupyterlab/jupyterlab

49 of 56 projects failed to build with the old tsc and were ignored

packages/services/examples/browser/tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

packages/services/examples/typescript-browser-with-output/tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

@typescript-bot
Copy link
Collaborator Author

lensapp/lens

6 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

webpack/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

luin/ioredis

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

react-bootstrap/react-bootstrap

test/tsconfig.json

  • error TS2345: Argument of type '(Element | ComponentClass<{}, any>) & Record<"setState", unknown>' is not assignable to parameter of type 'ReactInstance | null | undefined'.

tsconfig.json

  • error TS2345: Argument of type '(Element | ComponentClass<{}, any>) & Record<"setState", unknown>' is not assignable to parameter of type 'ReactInstance | null | undefined'.

@typescript-bot
Copy link
Collaborator Author

reduxjs/reselect

1 of 3 projects failed to build with the old tsc and were ignored

typescript_test/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

sindresorhus/got

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

@typescript-bot
Copy link
Collaborator Author

Tencent/vConsole

tsconfig.json

  • error TS2741: Property '0' is missing in type 'string[]' but required in type 'RegExpMatchArray'.
  • error TS2339: Property 'apply' does not exist on type 'string extends keyof T ? T[keyof T & string] : any'.
  • error TS2322: Type '() => ReadableStreamReader<Uint8Array>' is not assignable to type '{ (options: { mode: "byob"; }): ReadableStreamBYOBReader; (): ReadableStreamDefaultReader<Uint8Array>; (options?: ReadableStreamGetReaderOptions): ReadableStreamReader<...>; }'.

tsconfig.type.json

  • error TS2741: Property '0' is missing in type 'string[]' but required in type 'RegExpMatchArray'.
  • error TS2339: Property 'apply' does not exist on type 'string extends keyof T ? T[keyof T & string] : any'.
  • error TS2322: Type '() => ReadableStreamReader<Uint8Array>' is not assignable to type '{ (options: { mode: "byob"; }): ReadableStreamBYOBReader; (): ReadableStreamDefaultReader<Uint8Array>; (options?: ReadableStreamGetReaderOptions): ReadableStreamReader<...>; }'.

@typescript-bot
Copy link
Collaborator Author

trufflesuite/truffle

10 of 40 projects failed to build with the old tsc and were ignored

packages/hdwallet-provider/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.
    • file:///mnt/ts_downloads/hyper/node_modules/@types/node/globals.d.ts#L72 in app/tsconfig.json

@DanielRosenwasser
Copy link
Member

Just took a quick look

I think @ahejlsberg's PR at #50958 will fix the darkreader example, but I'm not sure about the got one (#50979 (comment))

vConsole seems like unfortunate fallout from a lib.d.ts change, but an annotation can help there.

The react-reselect one is likely correct, but the error message doesn't make it super obvious.

Not sure about react-bootstrap.

The rest is likely correct...

@RyanCavanaugh RyanCavanaugh closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants