Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewErrors] 4.9.0-dev.20221002 vs 4.8.4 #51030

Closed
typescript-bot opened this issue Oct 2, 2022 · 26 comments
Closed

[NewErrors] 4.9.0-dev.20221002 vs 4.8.4 #51030

typescript-bot opened this issue Oct 2, 2022 · 26 comments
Assignees

Comments

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 2, 2022

The following errors were reported by 4.9.0-dev.20221002, but not by 4.8.4
Pipeline that generated this bug
Logs for the pipeline run
File that generated the pipeline

This run considered 200 popular TS repos from GH (after skipping the top 0).

Investigation Status

Repo Errors Outcome
ant-design/ant-design 1
codex-team/editor.js 2
Successfully analyzed 105 of 200 visited repos
Outcome Count
Detected interesting changes 16
Detected no interesting changes 89
Git clone failed 2
Package install failed 52
Too many errors in old TS 39
Unknown failure 2
@typescript-bot
Copy link
Collaborator Author

ant-design/ant-design

tsconfig.json

  • error TS2352: Conversion of type '{ pagination: true; }' to type 'TableProps<any>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

@typescript-bot

This comment was marked as resolved.

@typescript-bot

This comment was marked as resolved.

@typescript-bot
Copy link
Collaborator Author

Eugeny/tabby

9 of 29 projects failed to build with the old tsc and were ignored

tabby-community-color-schemes/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-electron/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-linkifier/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-local/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-serial/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-ssh/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-telnet/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-terminal/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-terminal/tsconfig.typings.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-web-demo/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

@typescript-bot

This comment was marked as resolved.

@typescript-bot
Copy link
Collaborator Author

JedWatson/react-select

3 of 5 projects failed to build with the old tsc and were ignored

packages/react-select/src/tests/tsconfig.json

@typescript-bot

This comment was marked as resolved.

@typescript-bot
Copy link
Collaborator Author

lensapp/lens

6 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

webpack/tsconfig.json

@typescript-bot

This comment was marked as resolved.

@typescript-bot
Copy link
Collaborator Author

react-bootstrap/react-bootstrap

test/tsconfig.json

  • error TS2345: Argument of type '(Element | ComponentClass<{}, any>) & Record<"setState", unknown>' is not assignable to parameter of type 'ReactInstance | null | undefined'.

tsconfig.json

  • error TS2345: Argument of type '(Element | ComponentClass<{}, any>) & Record<"setState", unknown>' is not assignable to parameter of type 'ReactInstance | null | undefined'.

@typescript-bot
Copy link
Collaborator Author

reduxjs/reselect

1 of 3 projects failed to build with the old tsc and were ignored

typescript_test/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

sindresorhus/got

tsconfig.json

@typescript-bot

This comment was marked as resolved.

@typescript-bot

This comment was marked as resolved.

@typescript-bot

This comment was marked as resolved.

@typescript-bot
Copy link
Collaborator Author

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.
    • file:///mnt/ts_downloads/hyper/node_modules/@types/node/globals.d.ts#L72 in app/tsconfig.json

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Oct 3, 2022

Have to run to a meeting - if someone else can take a look, 💯

@RyanCavanaugh
Copy link
Member

Opened trufflesuite/truffle#5588 👀

@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Oct 3, 2022

https://github.com/Tencent/vConsole is broken by a more-accurate inference that ends up being used in a contravariant way (we should name this phenomenon).

@RyanCavanaugh
Copy link
Member

https://github.com/squidfunk/mkdocs-material absolutely has a bug but it's unclear what the correct code is; they wrote

let [foo] = someExpr || [];
switch (foo.toLowerCase()) {

@RyanCavanaugh
Copy link
Member

Opened squidfunk/mkdocs-material#4451

@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Oct 3, 2022

Codex has a real bug in their code, ref codex-team/editor.js#2131

@RyanCavanaugh
Copy link
Member

graphql-js got broken by a ts-expect-error being correctly resolved, ref #38009

@RyanCavanaugh
Copy link
Member

ioredis got broken by a ts-expect-error being correctly resolved by the in narrowing improvements

@RyanCavanaugh RyanCavanaugh self-assigned this Oct 4, 2022
@RyanCavanaugh
Copy link
Member

darkreader uses in in a way that we don't handle quite right #51059

@RyanCavanaugh
Copy link
Member

jupyterlab has a straightforward conflict with the node declaration file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants