Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the latest changes from typescript-DOM-lib-generator repo to make the latest APIs available #52025

Closed
8ma10s opened this issue Dec 26, 2022 · 1 comment
Assignees

Comments

@8ma10s
Copy link

8ma10s commented Dec 26, 2022

lib Update Request

I just want the latest changes from TypeScript-DOM-lib-generator repository to be applied to this repo so that I can use the latest APIs available.
In particular, I want PublicKeyCredential.isConditionalMediationAvailable, which is already available in the TypeScript-DOM-lib-generator's baseline file: https://github.com/microsoft/TypeScript-DOM-lib-generator/blob/0337998b669df62d10f3acb96cc2f7c2382bbfda/baselines/dom.generated.d.ts#L11245

I tried updating it myself using the scripts in TypeScript-DOM-lib-generator, but I had no luck: #52024
I couldn't find the specific documentation on how to "import" the latest generated file to this repository.

Configuration Check

My compilation target is ES2015 and my lib is the default.

Missing / Incorrect Definition

Sample Code

Documentation Link

It's already available in the MDN docs too, and has support by more than 2 browsers https://developer.mozilla.org/docs/Web/API/PublicKeyCredential
(This shouldn't matter anyway, because the change is already in the baselines/ folder of DOM-lib-generator repo.

@sandersn
Copy link
Member

sandersn commented Feb 1, 2023

Typescript 5.0 beta now has isConditionalMediationAvailable.

I think your PR was rejected by the bot because it updated too many files. The only 3 I update are dom.generated.d.ts, dom.iterable.generated.d.ts and webworker.generated.d.ts. I need to take a second look as to why we don't update the others.

@sandersn sandersn closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants