Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import type from = require('foo') fails to parse #56567

Closed
andrewbranch opened this issue Nov 27, 2023 · 0 comments · Fixed by #56568
Closed

import type from = require('foo') fails to parse #56567

andrewbranch opened this issue Nov 27, 2023 · 0 comments · Fixed by #56568
Assignees
@andrewbranch
Labels
Bug A bug in TypeScript Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Fix Available A PR has been opened for this issue Help Wanted You can do this
Milestone
TypeScript 5.4.0

Comments

@andrewbranch
Copy link
Member

There's still a problem with import type from = require('foo'): (playground link). That seems like a bug if it's expected that from is allowed to be the name of an imported type. Should that be fixed as part of this issue as well?

For context, I'm commenting here because I was linked to this bug from esbuild's issue tracker, and I need to figure out how to handle this kind of type syntax in esbuild.

Originally posted by @evanw in #56376 (comment)
@andrewbranch andrewbranch self-assigned this Nov 27, 2023
@andrewbranch andrewbranch added this to the TypeScript 5.4.0 milestone Nov 27, 2023
@andrewbranch andrewbranch added Bug A bug in TypeScript Help Wanted You can do this Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". labels Nov 27, 2023
@a-tarasyuk a-tarasyuk mentioned this issue Nov 27, 2023
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewbranch andrewbranch

Labels
Bug A bug in TypeScript Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Fix Available A PR has been opened for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 5.4.0
Development

Successfully merging a pull request may close this issue.

fix(56567): import type from = require('foo') fails to parse a-tarasyuk/TypeScript
2 participants
@andrewbranch @typescript-bot