Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.1] Pass throwIfNoEntry to fs.statSync #44584

Merged
merged 1 commit into from Jun 15, 2021

Conversation

DanielRosenwasser
Copy link
Member

Ports #41604 to TypeScript 4.1

See nodejs/node#35644 for why we have to do this to avoid potential regressions when users upgrade to Node 16.

Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.

See nodejs/node#33716
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 14, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@DanielRosenwasser DanielRosenwasser merged commit 13e7ae7 into release-4.1 Jun 15, 2021
@DanielRosenwasser DanielRosenwasser deleted the throwIfNoEntry-4.1 branch June 15, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants