Skip to content

Fix hermes command support #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2022
Merged

Fix hermes command support #2052

merged 6 commits into from
Aug 5, 2022
+122 −20

Conversation

AnatolyPristensky
Copy link
Contributor

Ready to merge version of #1325:

If the hermesCommand option is present in build.gradle then this path will be used as the path to the hermes executable when running codepush release-react

This allows the release-react command to be used in monorepos where the node_modules directory may be at the root of the monorepo rather then in the project and fixes this issue here: #1170

Chris Green and others added 4 commits March 13, 2021 19:48
@AnatolyPristensky
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AnatolyPristensky
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AnatolyPristensky AnatolyPristensky mentioned this pull request Aug 5, 2022
Closed
@AnatolyPristensky AnatolyPristensky merged commit 4a9996a into master Aug 5, 2022
@AnatolyPristensky AnatolyPristensky deleted the fix/hermes-command-support branch August 5, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyKirakosyan DmitriyKirakosyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnatolyPristensky @DmitriyKirakosyan