DownloadBuildArtifacts extractTars code is different from the one used by ExtractFiles

[luiszun]

Question, Bug, or Feature?
Type: Bug

Enter Task Name: DownloadBuildArtifacts

Environment

• Server - Azure Pipelines

  • If using Azure Pipelines, provide the account name, team project name, build definition name/build number: mscatapult, buildId:806464

• Agent - Hosted or Private: Hosted

  • If using Hosted agent, provide agent queue name: ubuntu 20.04

Issue Description

Specifically this call from DownloadBuildArtifacts:

azure-pipelines-tasks/Tasks/DownloadBuildArtifactsV0/file_helper.ts

Line 84 in b2e5863

tl.cp(`${extractedTarsPath}/.`, destination, '-r');

vs

azure-pipelines-tasks/Tasks/ExtractFilesV1/extractfilestask.ts

Line 230 in acc64cc

function tarExtract(file, destinationFolder) {

Both achieve the same, yet are different. The DownloadBuildArtifacts contains a ShellJS call to cp.
in my example, we happen to use extracted_tars (the same path hardcoded in the pipelines tasks). Causing a copy at the end of files to their same destination. This triggers a bug on ShellJS that wipes out all the files contents. I reported that (which is a regression) here: shelljs/shelljs#1092

Having the same codepath on this repo would prevent people from hitting this issue in the future (or it would have been caught earlier)

In summary: DownloadBuildArtifacts with extractTars enabled is causing us to get a bunch of files without content; whereas DownloadBuildArtifacts, followed by an ExtractFiles task works fine.

[github-actions]

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days