Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[botframework-streaming] Some named pipe tests are not passing after fixing their inconclusiveness #4462

Open
compulim opened this issue Apr 24, 2023 · 0 comments · May be fixed by #4494
Open
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

What package version of the SDK are you using.
main

What nodejs version are you using
18

What browser version are you using
Unrelated

What os are you using
Windows

Describe the bug

Some tests are not conclusive because some of their expectations are not running. After fixing them, some issues are discovered with the library. Tests that are failing and some investigations:

  • Streaming Extensions NamedPipe Library Tests > NamedPipe Transport Tests > throws when reading from a dead socket
    • This is an issue on production code.
    • Reading from a dead socket will never resolve/reject.
    • The only way to reject reading is: read from a live socket, close/error out the socket
  • Streaming Extensions NamedPipe Library Tests > NamedPipe Client Tests > sends without throwing
    • This is an issue on test code.
    • Without connecting the named pipe, the send() call will never resolve
    • The test code should connect to the server and respond, then the send() call will resolve and completing the scenario
  • Streaming Extensions NamedPipe Library Tests > NamedPipe Server Tests > sends without throwing
    • This is an issue on test code.
    • Without connecting the named pipe, the send() call will never resolve
    • The test code should connect to the client and respond, then the send() call will resolve and completing the scenario

To Reproduce

Currently, those offending tests are disabled by it.skip().

Steps to reproduce the behavior:

  1. Modify offending tests by changing it from it.skip() to it()
  2. Run npm test under /libraries/botframework-streaming

Expected behavior

All tests should pass.

Screenshots

image

image

image

Additional context

Add any other context about the problem here.

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 24, 2023
@tracyboehrer tracyboehrer removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
3 participants